Code Review Hell
Feb. 4th, 2004 12:26 pm![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
terryclothMandatory Code Reviews.
It wouldn't be so bad if we didn't have 57 bugs come in yesterday (for the four of us) that are all simple changes... if our code base was still exactly the same as the code base they're ported from, which it isn't.
And it wouldn't be so bad if the code I was reviewing wasn't hideously wrong.
But I've spent two hours code reviewing and getting code reviewed just of stuff from yesterday, and I'm not done yet. It looks like this might be a 33-50% productivity hit.
Although, on the other hand, the code I'm reviewing is hideously wrong, and it'd be bad for it to be checked in. Shudder.
It wouldn't be so bad if we didn't have 57 bugs come in yesterday (for the four of us) that are all simple changes... if our code base was still exactly the same as the code base they're ported from, which it isn't.
And it wouldn't be so bad if the code I was reviewing wasn't hideously wrong.
But I've spent two hours code reviewing and getting code reviewed just of stuff from yesterday, and I'm not done yet. It looks like this might be a 33-50% productivity hit.
Although, on the other hand, the code I'm reviewing is hideously wrong, and it'd be bad for it to be checked in. Shudder.
